Muawiya-contact commented on issue #327: URL: https://github.com/apache/hugegraph-ai/issues/327#issuecomment-4409316145
<html> <body> <!--StartFragment--><html><head></head><body><h1>Implementation Plan — #327</h1> <h2>Goal</h2> <p>Remove the silent-skip anti-pattern in <code>test_gremlin.py</code> so CI failures surface as <strong>failed</strong>, not <strong>skipped</strong>.</p> <hr> <h2>Steps</h2> <ol> <li><strong>Locate</strong> <code>setUpClass</code> in <code>hugegraph-python-client/src/tests/test_gremlin.py</code> (L41–52)</li> <li><strong>Choose a fix:</strong> <ul> <li><strong>Option A</strong> — Delete the <code>skip_gremlin_tests</code> probe entirely; let tests fail naturally</li> <li><strong>Option B</strong> — Replace <code>unittest.SkipTest</code> with <code>AssertionError</code> in the <code>except</code> block</li> </ul> </li> <li><strong>Run</strong> the full Gremlin test suite locally against a live endpoint to confirm no false skips</li> <li><strong>Verify</strong> CI reports <code>6 failed</code> (not <code>6 skipped</code>) when the endpoint is down</li> <li><strong>Open PR</strong> referencing #327, #325, #320</li> </ol> <hr> <h2>Scope</h2> Item | Detail -- | -- File | hugegraph-python-client/src/tests/test_gremlin.py Lines | L41–52 Tests affected | 6 Gremlin integration tests Labels | test python-client </body></html><!--EndFragment--> </body> </html> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
