imbajin commented on issue #327: URL: https://github.com/apache/hugegraph-ai/issues/327#issuecomment-4468887399
@Muawiya-contact Thanks for the follow-up. I agree with the direction here, and I am assigning this to you. For this one, the intended behavior should be fail-fast by default: - The Gremlin integration tests should not silently skip all 6 checks because the probe fails. - CI should report failures when the Gremlin endpoint is unavailable or misconfigured. - Local runs should also not skip automatically by default. For local development, please document the expected way to run these tests: start a HugeGraph Docker container quickly, using either the stable tag used by CI or a suitable latest/tagged image. If you add a skip path, it should be an explicit opt-in switch, such as an environment variable or test marker. It should not be based on automatically swallowing 404 / timeout / connection errors from the probe. So the expected direction is: remove the implicit silent-skip behavior, make probe failures visible by default, and document the Docker-based local setup path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
