imbajin commented on code in PR #2676:
URL: https://github.com/apache/hugegraph/pull/2676#discussion_r3323583276
##########
hugegraph-server/hugegraph-core/src/main/java/org/apache/hugegraph/task/ServerInfoManager.java:
##########
@@ -228,6 +238,32 @@ protected boolean graphIsReady() {
return !this.closed && this.graph.started() &&
this.graph.initialized();
}
+ protected synchronized void updateIsSingleNode(){
Review Comment:
This scheduler role change needs automated coverage. The PR changes when a
computer node can pass master-only scheduling checks and recalculates
`onlySingleNode`, but no test files are changed, so the standalone-computer
path and the master + worker + single-computer case are unguarded. Please add
tests that cover a single computer node scheduling a task and a mixed cluster
where one computer node must not make the whole deployment behave as
single-node.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
