imbajin commented on code in PR #2676:
URL: https://github.com/apache/hugegraph/pull/2676#discussion_r3323609447
##########
hugegraph-server/hugegraph-core/src/main/java/org/apache/hugegraph/task/DistributedTaskScheduler.java:
##########
@@ -441,7 +441,7 @@ public void waitUntilAllTasksCompleted(long seconds)
@Override
public void checkRequirement(String op) {
- if (!this.serverManager().selfIsMaster()) {
+ if (!this.serverManager().selfIsMasterOrSingleComputer()) {
Review Comment:
`DistributedTaskScheduler` now also depends on
`selfIsMasterOrSingleComputer()`, but this scheduler never refreshes the new
`onlySingleNode` flag. `TaskManager.scheduleOrExecuteJobForGraph()` only calls
`updateIsSingleNode()` inside the `StandardTaskScheduler` branch, while each
scheduler owns its own `ServerInfoManager` initialized with `onlySingleNode =
false`. In `scheduler.type=distributed`, a standalone `server.role=computer`
node therefore still fails this requirement check permanently instead of
passing as a standalone computer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
