imbajin commented on code in PR #351: URL: https://github.com/apache/hugegraph-ai/pull/351#discussion_r3338177842
########## hugegraph-llm/src/hugegraph_llm/api/graph_api.py: ########## @@ -0,0 +1,68 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import json + +from fastapi import APIRouter, HTTPException, status + +from hugegraph_llm.api.models.rag_requests import GraphConfigRequest, GraphExtractRequest +from hugegraph_llm.config import huge_settings, prompt +from hugegraph_llm.flows import FlowName +from hugegraph_llm.flows.scheduler import SchedulerSingleton +from hugegraph_llm.utils.log import log + + +def _apply_graph_config(client_config: GraphConfigRequest | None) -> None: + if client_config: + huge_settings.graph_url = client_config.url Review Comment: ‼️ **Keep graph config request-local** Evidence: `_apply_graph_config()` writes `client_config` into the module-level `huge_settings` before scheduling. Impact: one `/graph/extract` request can leave its HugeGraph URL/name/credentials active for later requests with no `client_config`, and concurrent requests can overwrite each other. Please pass these settings through request-local flow/client construction or restore them in a request-scoped context so this endpoint does not mutate shared process state. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
