Nishieee commented on PR #351: URL: https://github.com/apache/hugegraph-ai/pull/351#issuecomment-4616393654
@LRriver thanks for the detailed review. here's what i'm taking and where i landed on the open calls. api contract: - remove triples, property-graph only for this PR. it never actually worked here: post_deal only returns vertices/edges, and InfoExtract only emits triples when no schema is set, but this flow always sets one. can add it later with a real triples shape. - add GraphExtractResponse (status / result / warnings / meta) instead of returning the raw flow dict. - add a dedicated GraphExtractClientConfig (all-optional, extra="forbid") so the implicit 127.0.0.1:8080 / hugegraph defaults can't kick in. - drop the request-level url override and use the configured server url. can add a server-side allowlist later if multi-server support is needed. - keeping the strict request-local checks already added (named schema requires local config, client_config.graph must match the schema name, no field-by-field fallback into globals). tests: - response envelope shape (status / result / warnings / meta) - texts accepting both a string and a list - mismatched client_config.graph rejected - inline schema + client_config behavior - property-graph-only output - /rag, /text2gremlin, /config/graph still registering structural: - moving the models to graph_extract_requests.py / graph_extract_responses.py and the route to graph_extract_api.py, both in this PR. - the GraphExtractService.extract_sync(req) wrapper is the one i'd like your call on: happy to add it here, or land it as a quick follow-up so this PR stays focused on the contract + security fixes. which do you prefer? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
