imbajin commented on code in PR #348: URL: https://github.com/apache/hugegraph-computer/pull/348#discussion_r3339022301
########## vermeer/Dockerfile: ########## @@ -15,9 +15,11 @@ # limitations under the License. # FROM golang:1.23-alpine AS builder +RUN apk add --no-cache npm bash curl COPY ./ /src/ WORKDIR /src/ ENV CGO_ENABLED="0" +RUN ./scripts/download_ui_assets.sh Review Comment: ‼️ **Ship the release metadata in the Docker image** Evidence: this Docker build now downloads UI assets and embeds them into `/go/bin/app`, while the final stage only copies the binary, config, and zoneinfo. Impact: the image redistributes the bundled frontend assets without the `release-docs/LICENSE`, `release-docs/NOTICE`, and license bundle that the tarball path now carries. Please copy the release metadata into the final image, or otherwise make the same notice bundle available in the shipped image. ########## vermeer/Dockerfile: ########## @@ -15,9 +15,11 @@ # limitations under the License. # FROM golang:1.23-alpine AS builder +RUN apk add --no-cache npm bash curl COPY ./ /src/ WORKDIR /src/ ENV CGO_ENABLED="0" +RUN ./scripts/download_ui_assets.sh RUN cd asset && go generate Review Comment: ⚠️ **Add CI coverage for the new Vermeer UI build path** Evidence: this PR adds npm asset downloads, `go generate` embedding, Docker build changes, and release metadata packaging, but the current PR checks only report license/security jobs for this head; the existing workflows do not exercise this Vermeer build path. Impact: dependency download, asset embedding, and Docker packaging regressions can merge without a build signal. Please add a Vermeer-oriented job that runs the asset download and embedding path, ideally including the Docker/package path touched here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
