bitflicker64 commented on issue #3133:
URL: https://github.com/apache/hugegraph/issues/3133#issuecomment-5523810311
Go ahead, it is yours as far as I am concerned. I opened this one but I am
not a
committer here, so I cannot set the assignee; a maintainer will have to do
that.
Worth knowing before you start: #3119 landed after this was filed and fixed a
good part of it. On master `98477f0f5`:
- The `:` and whitespace separator case is done. `set_prop` handles both
separators now and collapses duplicate definitions, and CI covers it in
`docker/test/test-docker-entrypoint.sh`.
- `PASSWORD` reaches `init-store` on stdin, not as a process argument.
- `PASSWORD` no longer no-ops when init-store is disabled, and
`enable-auth.sh`
runs outside the init-flag guard, so the upgraded-volume case is covered.
What is still open:
- The Gremlin/REST split, though the mechanism moved. See the diagram I just
added to the description: `enable-auth.sh` appends a second definition to a
config it did not write, commons-configuration2 2.8.0 takes the first of
the
duplicate pair and snakeyaml 2.2 takes the last, so the two sides land on
different authenticators with no error from either.
- Escaped keys and continuation lines still confuse `set_prop`. A mounted
`auth\.admin_pa=pa` plus the appended `auth.admin_pa=<password>` is two
definitions of one key, and `getString` returns `pa`, so the env var is
silently dropped. A `pd.peers` value continued onto a second line leaves
the
continuation behind as a stray property.
- `set_prop` interpolates the value into the `sed` command, so when the key
already exists the password ends up in sed's argv and is visible in `ps`.
The
shipped conf has `auth.admin_pa` commented out, so a default first boot
takes
the append branch and is clean; a mounted or persisted conf hits it.
Your plan lines up with the parts that are left. I would reproduce against
master first so you are not fixing the ones that are already gone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
