Adarsh-Me commented on issue #3133: URL: https://github.com/apache/hugegraph/issues/3133#issuecomment-5528332631
Opened PR #3192 with the fixes for the parts still open on master: - **Gremlin/REST authenticator split** — enable-auth.sh appends are now guarded per file (only an absent or commented-out definition triggers an append), re-runs are idempotent, and the entrypoint aligns both sides first: a yaml authenticator is propagated into rest-server.properties and vice versa, so the default StandardAuthenticator can no longer split the pair. Genuine mismatches get a loud WARN instead of silent divergence. - **Escaped keys and continuations** — property rewriting moved to props.awk, which implements the java.util.Properties line grammar (escapes, ':'/whitespace separators, continuations, first-definition-wins duplicates) and rewrites the first definition in place, so mounted configs like one carrying `auth\.admin_pa=pa` no longer grow duplicate definitions that HugeConfig resolves to `pa`. - **PASSWORD in `ps`** — the value no longer interpolates into a sed command line; it travels via environment variable into awk, so argv stays clean. Both test suites pass locally (the extended unit suite and the full entrypoint harness, including the complex-secret round-trips). @bitflicker64 your updated diagram and 'what is still open' list were exactly the roadmap — I followed the reproduce-on-master-first advice and skipped what #3119 already fixed. @imbajin could you take a look when you get a chance? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
