SebastianGruza commented on PR #2994:
URL: https://github.com/apache/hugegraph/pull/2994#issuecomment-5529765791
Cross-backend results for this branch (head `5cb9a51`), from the same run
reported in #3090: 35 label-semantics queries (`neq` / `without` / `within` /
conflicting labels / `or` / `and` / `not`, negative labels across `barrier()`
and `sideEffect()`, incoming edges from multi-label sources, vertices with
label + range index; edge labels with sort keys) executed through REST/Gremlin
against HStore (PD + 3 stores) and RocksDB on the same server build, compared
as sets of element ids.
**Before** — master `98477f0`, both backends:
```
g.V().has('age',gte(30)).hasLabel(without('person','robot'))
-> Can't do index query with [LABEL != 5, LABEL != 6] and [12 >= 30]
g.V().hasLabel(without('person')).barrier().has('age',gte(60))
-> Don't accept query based on properties [age] that are not indexed in
any label, may not match range/not-equal
```
Both throw on RocksDB as well, so this is server-side condition resolution,
not a backend issue. The other 33 cases are identical sets on both backends
already on master.
**After** — master + this branch (+ #3184 and the since-merged #3182): 35/35
identical sets; the two queries above return 0 and 100 vertices respectively,
identically on both backends.
**Version axis** (RocksDB master vs RocksDB with the branch, backend held
constant): 168 of 174 queries across all four sections (sort-key pushdown,
range-index paging, label semantics, `within` × search × range) return
identical id sets; the only differences are the two `without()` cases above
(the remaining 4 are REST string-predicate rejections present on both
versions). So on this corpus the branch changes visible results exactly where
it intends to and nowhere else.
Caveat: the "after" run was the combined branch, not #2994 alone; #3184 only
touches the HStore pushdown path and #3182 is now in master, so attribution of
the two fixes to this PR is by elimination. I can run #2994 alone on request.
Raw reports (ids included) and the case list:
https://github.com/SebastianGruza/hugegraph-oracle-suite —
`results/compare_master.txt`,
`results/compare_master-oracle_vs_combined-oracle.txt`, finding F9 in
`docs/findings.md`. Happy to re-run on the next head — ping me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
