vaijosh commented on code in PR #3164:
URL: https://github.com/apache/hugegraph/pull/3164#discussion_r3988514994
##########
hugegraph-store/hg-store-core/src/main/java/org/apache/hugegraph/store/util/HgStoreException.java:
##########
@@ -33,11 +33,9 @@ public class HgStoreException extends RuntimeException {
public static final int EC_RKDB_DOMERGE_FAIL = 1207;
public static final int EC_RKDB_DOGET_FAIL = 1208;
public static final int EC_RKDB_PD_FAIL = 1209;
- public static final int EC_RKDB_TRUNCATE_FAIL = 1212;
public static final int EC_RKDB_EXPORT_SNAPSHOT_FAIL = 1214;
public static final int EC_RKDB_IMPORT_SNAPSHOT_FAIL = 1215;
- public static final int EC_RKDB_TRANSFER_SNAPSHOT_FAIL = 1216;
- public static final int EC_METRIC_FAIL = 1401;
+ public static final int EC_RKDB_SNAPSHOT_SAVE_BUSY_FAIL = 1217;
Review Comment:
Addressed Review comments.
##########
hugegraph-store/hg-store-core/src/main/java/org/apache/hugegraph/store/options/RaftRocksdbOptions.java:
##########
@@ -55,6 +56,15 @@ private static RocksdbConfig getRocksdbConfig(HugeConfig
options) {
}
private static void registerRaftRocksdbConfig(HugeConfig options) {
+ // StorageOptionsFactory.releaseAllOptions() (called by test setup
between runs)
+ // does not clear its table-format-config table, so registering
RocksDBLogStorage's
+ // config more than once per JVM throws IllegalStateException.
Register only once.
+ synchronized (RaftRocksdbOptions.class) {
Review Comment:
Addressed Review comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
