vaijosh commented on PR #3164: URL: https://github.com/apache/hugegraph/pull/3164#issuecomment-5651805274
> Blocking: no. Summary: The previous rounds' findings are resolved at this head. Snapshot save and `compactRange()` now share a per-partition `ReentrantLock`, a busy save reports `RaftError.EBUSY` instead of restarting the raft node, a compaction that meets a running save waits up to 10s before skipping with a WARN, and the `data/` check sits after the `should_not_load` return. Evidence: exact-head diff and the incremental diff `468e2343..1c6bc23a` (`BusinessHandlerImpl.java:1440-1463`, `SnapshotHandler.java`, `PartitionStateMachine.java`); all 24 checks on `1c6bc23a` pass, and the `store` job log shows `CoreSuiteTest` (8 tests, including the skip path: `Partition 4 skip dbCompaction ... after 200ms wait`), `BatchGraphIsolationTest` (6) and `RaftSuiteTest` (6) passing. Optional nit: the comment at `BusinessHandlerImpl.java:1446-1449` still says the next compaction pass will succeed, but the event-driven triggers are one-shot. Thanks @bitflicker64. I have fixed the comment at `BusinessHandlerImpl.java:1446-1449`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
