imbajin commented on code in PR #3237: URL: https://github.com/apache/hugegraph/pull/3237#discussion_r4094243350
########## hugegraph-server/hugegraph-dist/src/assembly/static/conf/graphs/hugegraph.properties: ########## @@ -4,6 +4,10 @@ gremlin.graph=org.apache.hugegraph.HugeFactory # cache config #schema.cache_capacity=100000 +# hstore only: check the schema version in PD every 10s, so that schema +# changes made through other servers are visible here within about 10s Review Comment: ⚠️ [P2] Document the rollout conditions for the convergence claim. During a rolling upgrade, an old Server does not write SCHEMA_VERSION for updates/status changes, so an upgraded reader can keep its unchanged version and stale cache indefinitely. Upgrading that writer later does not itself publish the missed mutation. Please qualify this example and the paired user documentation: the convergence guarantee requires participating Servers to run the new implementation with synchronization enabled and polling active, successful version publication, and a reachable PD. Also describe how to handle DDL performed during the mixed-version window. This only requests an accurate deployment contract, not a mixed-version compatibility layer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
