bitflicker64 commented on code in PR #498:
URL: https://github.com/apache/hugegraph-doc/pull/498#discussion_r4097187555
##########
content/en/docs/config/config-option.md:
##########
@@ -135,6 +135,8 @@ Basic Config Options and Backend Config Options correspond
to configuration file
| pd.peers | 127.0.0.1:8686
| The addresses of pd nodes, separated with commas. Only used by the
hstore backend.
|
| schema.illegal_name_regex | .*\s+$|~.*
| The regex specified the illegal format for schema name.
|
| schema.cache_capacity | 10000
| The max cache size(items) of schema cache.
|
+| schema.sync.enabled | true
| Whether to write a per-graph schema version to PD on every schema
change and check it periodically, so that a schema change made through another
server clears this server's schema cache. Only for the hstore backend. Set
false to keep the previous behavior: no version writes, no checks. The
convergence bound holds only when every server of the graph runs a release with
these options, with schema.sync.enabled=true, schema.sync.reconcile_interval
above 0 and PD reachable. Older servers write no version for schema updates, so
after a rolling upgrade make one schema change, or restart the servers, to
reload every server's schema cache. |
Review Comment:
Minor: These two rows (and CN lines 137-138) give no release for the
options. They exist only in apache/hugegraph#3237, which is still open; `git
grep schema.sync` on apache/hugegraph master finds nothing, and master's
`<revision>` is 1.7.0, the latest release. A 1.7.0 server that reads
`schema.sync.enabled=true` only logs "The config option 'schema.sync.enabled'
is redundant" (`HugeConfig.java:113`) and keeps the old behavior. So a reader
running 1.7.0 with several HStore servers could take this page to mean schema
caches already converge across servers. The same table already marks
release-specific content with "For version 1.7.0+" in the `backend` row.
Requested change: add a short release note to both rows in EN and CN, for
example "Available since the release that includes apache/hugegraph#3237" or
the concrete version once it is known, and keep this PR unmerged until #3237
lands.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
