Copilot commented on code in PR #498: URL: https://github.com/apache/hugegraph-doc/pull/498#discussion_r4099721252
##########
content/cn/docs/config/config-option.md:
##########
@@ -134,6 +134,8 @@ HStore 后端还会从图配置文件 `{graph-name}.properties` 中读取以下
| pd.peers | 127.0.0.1:8686
| The addresses of pd nodes, separated with commas. Only used by the
hstore backend.
|
| schema.illegal_name_regex | .*\s+$|~.*
| The regex specified the illegal format for schema name.
|
| schema.cache_capacity | 10000
| The max cache size(items) of schema cache.
|
+| schema.sync.enabled | true
| Whether to write a per-graph schema version to PD on every schema
change and check it periodically, so that a schema change made through another
server clears this server's schema cache. Only for the hstore backend. Set
false to keep the previous behavior: no version writes, no checks. The
convergence bound holds only when every server of the graph runs a release with
these options, with schema.sync.enabled=true, schema.sync.reconcile_interval
above 0 and PD reachable. Older servers write no version for schema updates, so
after a rolling upgrade make one schema change, or restart the servers, to
reload every server's schema cache. |
+| schema.sync.reconcile_interval | 10
| The interval in seconds to check the schema version of a graph in PD.
A schema change made through another server is visible on this server within
about this interval. 0 means never check: the version is still written for
other servers, and a failed write is retried by the next schema change.
|
Review Comment:
`CoreOptions` constrains this option to 0–3600 seconds, but this row only
documents the special case `0`. Please include the upper bound so users do not
discover the validation failure only after setting a larger interval.
##########
content/en/docs/config/config-option.md:
##########
@@ -135,6 +135,8 @@ Basic Config Options and Backend Config Options correspond
to configuration file
| pd.peers | 127.0.0.1:8686
| The addresses of pd nodes, separated with commas. Only used by the
hstore backend.
|
| schema.illegal_name_regex | .*\s+$|~.*
| The regex specified the illegal format for schema name.
|
| schema.cache_capacity | 10000
| The max cache size(items) of schema cache.
|
+| schema.sync.enabled | true
| Whether to write a per-graph schema version to PD on every schema
change and check it periodically, so that a schema change made through another
server clears this server's schema cache. Only for the hstore backend. Set
false to keep the previous behavior: no version writes, no checks. The
convergence bound holds only when every server of the graph runs a release with
these options, with schema.sync.enabled=true, schema.sync.reconcile_interval
above 0 and PD reachable. Older servers write no version for schema updates, so
after a rolling upgrade make one schema change, or restart the servers, to
reload every server's schema cache. |
+| schema.sync.reconcile_interval | 10
| The interval in seconds to check the schema version of a graph in PD.
A schema change made through another server is visible on this server within
about this interval. 0 means never check: the version is still written for
other servers, and a failed write is retried by the next schema change.
|
Review Comment:
`CoreOptions` constrains this option to 0–3600 seconds, but this row only
documents the special case `0`. Please include the upper bound so users do not
discover the validation failure only after setting a larger interval.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
