imbajin commented on code in PR #2871:
URL: https://github.com/apache/hugegraph/pull/2871#discussion_r4106276006


##########
hugegraph-store/hg-store-core/src/main/java/org/apache/hugegraph/store/raft/PartitionStateMachine.java:
##########
@@ -105,6 +106,9 @@ public void onApply(Iterator iter) {
                               done.getOperation().getOp(),
                               done.getOperation().getReq());
                 }
+                iter.setErrorAndRollback(1, new 
Status(RaftError.ESTATEMACHINE, t.getMessage()));

Review Comment:
   Confirmed independently against jRaft 1.3.13 and fixed in 3e028d300 in both 
PD and Store: the exception message is now a data argument to a fixed "%s" 
format. The existing real-FSM tests now inject "%s" and a trailing "%": PD 
failed 2/4 before the fix; after the fix PD 4/4 and Store 10/10 passed. A 
separate SDK check covered plain text, format directives and a null message. 
Full clean compile passed; new-head CI remains pending.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to