imbajin commented on PR #2871: URL: https://github.com/apache/hugegraph/pull/2871#issuecomment-5817987988
Fixed the Store core CI failure in HgSnapshotHandlerTest. The test treated compactionDone as a terminal state, but the subsequent successful snapshot resets it to compactionCanStart. In the failed CI log, compaction finished at 16:14:54.001 and the successful snapshot released the lock at 16:14:54.024; the test polled every 50 ms and missed that transient state. The test now directly waits for and asserts path-lock release after interruption, while confirming the snapshot range lock is still owned. The redundant second compaction and transient-state assertion are removed; production code is unchanged. A negative control that removes unlock(path) fails at the retained lock-release assertion, demonstrating that the original regression is still detected. I had observed the same failure locally earlier but accepted passing reruns without resolving this race. That validation gap is now addressed. Validation: full clean compile, formatting and the Store core profile passed (37 Store tests, zero failures). The targeted negative control failed as expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
