byteayan commented on code in PR #3244:
URL: https://github.com/apache/hugegraph/pull/3244#discussion_r4118485145
##########
hugegraph-server/hugegraph-core/src/main/java/org/apache/hugegraph/HugeGraph.java:
##########
@@ -273,8 +272,6 @@ public interface HugeGraph extends Graph {
AuthManager authManager();
- RoleElectionStateMachine roleElectionStateMachine();
-
void switchAuthManager(AuthManager authManager);
Review Comment:
Added a "Migration notes" section to the PR description that names this
break (the removed method and the `masterelection` types it returned, the
scheduler constructor changes, and the removed config keys) and says what
callers should do. I went with the note over a deprecated bridge because #3082
set no removal version for this API, and a bridge would have to keep the
deleted `RoleElectionStateMachine` type alive just to return a machine that
nothing starts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
