n24q02m commented on PR #499: URL: https://github.com/apache/hugegraph-doc/pull/499#issuecomment-5944040207
Thanks for the second pass — both points are correct and the page has been corrected. ## What changed **Release qualifier up front.** The scope section now states that no row on the page describes a released HugeGraph version, spells out the two request forms a released build exposes (`GET ?cypher=` and `POST application/json` with a raw body), and says that released versions take no bound parameters. **Per-row availability.** The request-forms table gained an *In a released version* column. `GET ?cypher=` and the raw-body `POST` are marked available; `POST text/plain` and the JSON-object bound-parameter form are marked *No — introduced by #238*, with a note that the JSON object form is not available in any release and that on released versions a `$param` statement runs with the binding bound to `null` and returns no rows. That now agrees with the guide's *Known limitations* bullet instead of contradicting it. **Provenance corrected.** The tested commit link points at `apache/hugegraph@27a7c9b` rather than the contributor fork, and the page records that the commit has diverged from `master` (10 commits ahead, 5 behind) while `master` declares `tinkerpop.version` `3.5.1` and its `CypherAPI` is `@Consumes(APPLICATION_JSON)` with a raw `String cypher` body. The `hugegraph/hugegraph#238` reference now records that the PR is open and unmerged against the `task/tp381-3-upgrade-validation` branch. Both the English and Chinese pages carry the same change; statement lines stay byte-identical between locales. One question so the wording matches your intent: the tested tree is a TinkerPop 3.8 development line, so if `master` is the only thing readers should be told about, the alternative is to move all of the request-form and binding detail behind an explicit *not in any release* heading rather than keeping it in the table with a column. Happy to restructure that way if you prefer it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
