n24q02m commented on PR #499:
URL: https://github.com/apache/hugegraph-doc/pull/499#issuecomment-6072067866
Addressed the open review threads; pushed as `1481d96` (merge of current
`master`), `2079bd0`, and `ad1d032`.
**`data/docs_nav.json` expected stats (blocking)** — regenerated
`DOCS_NAV_EXPECTED_STATS` by running the full `versioning.py build` pipeline at
the merged head for all five versions. `latest` is now `pages: 95, treeSha256:
fd869e87…` (the 92-page nav from master plus the three new pages). The three
new nav entries resolve to nothing on the pinned release content, so each
historical version's `removed` count rises by exactly 3 (1.7: 5→8, 1.5: 13→16,
1.3: 22→25, 1.0: 21→24); the historical `treeSha256`s are unchanged, matching
the mechanism described in the review. `validate` passes for all five versions
locally, and the versioning unit tests pass.
**Missing-binding scope** — both language versions of the compatibility page
and the guide's Known limitations bullet now state that on the tested tree the
missing-binding execution error applies to every request form, including `GET
?cypher=` and raw-body `POST`, replacing the released null-and-no-rows
behaviour, per the #3289 code path.
**Released-form scoping** — the scope section now attributes the two request
forms to 1.7.0 explicitly and notes that releases before 1.7.0 expose the same
forms under `/graphs/{graph}/cypher`.
**Migration guide step 1** — classification now points at the Known
limitations section (which describe released behaviour); the compatibility
notes are described as the development-tree record only. The English page is
brought in line with the Chinese page here.
**Vertex ID strategy (step 3)** — the reader is now told to pick the
strategy before importing: `idStrategy = "PRIMARY_KEY"` with a Neo4j business
key in `idFields` and edge endpoints expressed through those same key fields,
or `idStrategy = "CUSTOMIZE_STRING"` to keep the Neo4j node id; pre-created
labels must use the same strategy (automatic creation does not convert
`PRIMARY_KEY` to `CUSTOMIZE_STRING`), and step 2 is optional when the Sink
`mappings` configuration creates the schema.
**Example schema assumption** — the examples now state they assume
`nullableKeys("age", "city")` on `person` and nullable `knows` properties, and
that on the released default schema the create/update examples fail the
non-null property check.
The earlier threads (the #238→#3289 provenance row, the stale ahead/behind
counts, and the disclaimer scoping) were addressed by the earlier commits on
this branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
