bitflicker64 commented on PR #3218: URL: https://github.com/apache/hugegraph/pull/3218#issuecomment-5956588162
Status at `7b76b8747` (your master merge) on the points from your 2026-10-01 review. The chart is unchanged since `0e754b98c` apart from one README limitation bullet (`d05741d9c`). **Org-fork review (hugegraph/hugegraph#221).** Your four open threads there (checksum `resourceVersion`, `maxUnavailable`, the startup-probe budget, the per-Pod Gremlin `helm test`) were fixed in `f7c2f312a` and `0e754b98c`, and each thread describes its fix. Your 2026-09-24 `CHANGES_REQUESTED` review (at `3996bb127`) is still the PR's review decision. The Hubble `existingSecret` escaping case you +1'd is also fixed in `0e754b98c`: the wrapper now rejects a PD secret with backslashes or leading/trailing whitespace instead of writing it. Codex posted seven new findings on `7b76b8747` on 2026-10-02; those are on my side and not yet assessed. **Coverage gate.** This PR touches only `helm/**`, `helm-chart-ci.yml` and the root `README.md`. `pd-store-ci.yml` runs on pull requests only for module paths, so the PD, Store and hstore jobs do not run here and upload no coverage, while `server-ci` and `commons-ci` do. With no Codecov config in the repo, the project number compares that partial upload with master's full one: 36.73% against 41.57%, 536 files against 793, so `codecov/project` fails. `codecov/patch` passes. No Java changes, so the drop is upload scope, not lost coverage. For reference, #3246 merged on 2026-10-02 with `codecov/project` failing (-0.02%, with PD/Store running). **Store restore procedure.** Unchanged: the README's Disaster Recovery section is the same as at `0e754b98c` (replace the Pod and keep its PVC; the empty-PVC retirement only on images with #3234), and the docs runbook describes the same procedure. **Docs (apache/hugegraph-doc#494).** Written against this chart at `0e754b98c`, all review threads answered, CI green. Docs master gained one commit on 2026-10-02 (apache/hugegraph-doc#507); it merges cleanly. Two README sentences now trail the docs (the presets table says "PD/Store PDBs"; the no-resources note says "Fine on a single node"); that README fix is on my side. **Merge order.** apache/hugegraph-doc#494 links to `helm/hugegraph` on apache master and installs from that path, so it has to merge after this PR. The one thread left open there tracks this; it is a merge-order decision, not something the docs can fix. **Needed from you:** 1. Re-check the four hugegraph/hugegraph#221 threads and resolve them if the fixes hold, then clear or update the `CHANGES_REQUESTED` review. 2. Say whether the coverage assessment above settles the gate. 3. Review and merge this PR before apache/hugegraph-doc#494. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
