bitflicker64 commented on PR #3132: URL: https://github.com/apache/hugegraph/pull/3132#issuecomment-5612571695
Pushed the three-line fix as `b94ff5d1`, since it is documentation only and the wording was actively misleading. Above I said I would rather flag it than push into a PR under review, so to close that loop: this is the flagged change and nothing else. `templates/NOTES.txt` now says `/v1/ready` is the default and why, and the two Configuration rows carry `/v1/ready` in the Default column. The rows also replace the old reason. They said `/v1/ready` "exists only on PD images from 1.8.0", which reads as though an older image would reject it; it does not, it answers 200 like every other unmapped `/v1/` path, which is the N2 problem in the comment above. They now say to set `/v1/health` on images predating apache/hugegraph#3189 and give that as the reason. No template behaviour change: renders stay 16/14/16, lint is clean on all three presets and the 63 unit tests pass. The identical fix is on `hugegraph/hugegraph` `helm-dev` as `36838a17`, which additionally goes to chart 0.1.7 and repackages, because 0.1.6 is already tagged and its content should not change under it. `templates/NOTES.txt` is byte-identical across both branches at blob `eb153ff8`, as are `values.schema.json` and `tests/`. One thing I did not touch: helm-dev's README has a fourth mention of `/v1/health` as the default at line 362, but it sits inside an "Upgrading to 0.1.4 from 0.1.3" note and correctly describes what the default was at 0.1.4. That is accurate history, so it stays. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
