imbajin commented on code in PR #3261:
URL: https://github.com/apache/hugegraph/pull/3261#discussion_r4179002786
##########
.github/workflows/cluster-test-ci.yml:
##########
@@ -63,8 +63,27 @@ jobs:
- name: Run simple cluster test
run: |
- mvn test -pl hugegraph-cluster-test/hugegraph-clustertest-test -am
-P simple-cluster-test
+ timeout 45m mvn test -pl
hugegraph-cluster-test/hugegraph-clustertest-test \
Review Comment:
Rechecked the upstream workflow state: Cluster Test CI is still
disabled_manually. The workflow file has simple/multi cluster commands, but
that does not establish that either profile ran on this PR head. Keeping this
open for the separate CI work; local compilation/unit tests and package
validation are not substitutes for those cluster runs.
##########
.asf.yaml:
##########
@@ -41,8 +41,7 @@ github:
- Analyze (java)
- CodeQL
- check-license
- - build-server (memory, 11)
- - build-commons (11)
+ - build-server (memory, 17)
Review Comment:
Rechecked the current configuration: .asf.yaml requires the fixed Server
memory tests gate, while Commons is explicitly optional. Commons still runs on
pull requests, and the transitional build-commons (11) bridge checks the
configured JDK and Commons result. The old versioned check name is outdated,
but the merge-gate policy concern is not fixed by the Java 11 bytecode repair
or PR concurrency updates. Reopened and kept open for the separate CI-policy
work. The corresponding org discussion is
https://github.com/hugegraph/hugegraph/pull/231#discussion_r4177647409 .
##########
hugegraph-store/hg-store-node/src/test/java/org/apache/hugegraph/store/node/controller/FixGraphIdControllerTest.java:
##########
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hugegraph.store.node.controller;
+
+import java.util.Collections;
+import java.util.LinkedHashMap;
+import java.util.Map;
+
+import org.apache.hugegraph.store.util.HgStoreException;
+import org.junit.Assert;
+import org.junit.Test;
+
+public class FixGraphIdControllerTest {
Review Comment:
Rechecked the latest tree and reopened this: FixGraphIdControllerTest still
lives under hg-store-node/src/test/java, and store-core-test includes
GraphIDManagerTest but not this controller test. There is no explicit
Vintage/discovery bridge in hg-store-node. Earlier local checks or a successful
package build do not establish CI execution. Keeping this in the separate CI
follow-up until an executed FixGraphIdControllerTest report is available for
the updated head.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
