bitflicker64 commented on code in PR #787:
URL:
https://github.com/apache/hugegraph-toolchain/pull/787#discussion_r4199144960
##########
.github/workflows/ci.yml:
##########
@@ -85,10 +85,9 @@ jobs:
if: steps.scope.outputs.needsFixture == 'true'
uses: ./.github/actions/get-hugegraph-commit
with:
- # TODO(apache/hugegraph#3263): switch the temporary source to ASF
after merge.
- repository: hugegraph/hugegraph
- ref: codex/cypher-minimal-compat
- expected-commit: 4c162f539b906fa06dd83228e3691b77fa5b77d7
+ repository: apache/hugegraph
+ ref: master
Review Comment:
Important: `ref: master` together with `expected-commit: d9abcd4...` breaks
as soon as apache/hugegraph master moves. `get-hugegraph-commit/resolve.cjs`
resolves `master` to the current tip and throws `Server ref moved` when that
differs from the expected SHA. `checkout-server.sh` fetches `SERVER_FETCH_REF`
with `--depth 1` and exits with `Server checkout mismatch` in the same case.
Master is at d9abcd4 today and took 47 commits in the last month, so the next
upstream merge fails this plan step, every `setup-candidate-sdk` caller (its
default `ref` is also `master`) and a direct `docker build` of hugegraph-loader
and hugegraph-hubble (`SERVER_FETCH_REF=master`). All of them stay red until
someone edits this repo. The 1.7 baseline avoids this by using the immutable
`refs/tags/1.7.0`.
Fetching by SHA keeps the same lock: `git fetch --depth 1 origin
d9abcd4317fb36128e7e4d209139ec7f3a28cdfc` works against
github.com/apache/hugegraph, and `repos.getCommit` accepts a SHA as `ref`.
Please use the SHA (or an immutable tag) as `ref` here, in the
`setup-candidate-sdk` default, in both Dockerfiles' `SERVER_FETCH_REF` and in
the docs/java17-migration.md example.
##########
.github/actions/upload-coverage/action.yml:
##########
@@ -16,6 +16,8 @@ runs:
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v7
with:
- token: ${{ inputs.token }}
+ use_oidc: true
+ disable_search: true
+ fail_ci_if_error: true
Review Comment:
Minor: `fail_ci_if_error: true` is new, and it makes a Codecov upload error
fail the Client, Loader and Hubble test jobs. Fork PRs never use OIDC:
codecov-action v7 detects the fork and uploads tokenless, as this PR's own
client-ci log shows (`Fork detected`,
`TOKENLESS=hugegraph:fix/java17-sdk-build-contract`). A Codecov outage or
tokenless rate limit then turns required CI red for reasons unrelated to the
change. Please keep `use_oidc` but drop `fail_ci_if_error`, or set it only for
`push` events (for example `fail_ci_if_error: ${{ github.event_name == 'push'
}}`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
