imbajin commented on code in PR #511:
URL: https://github.com/apache/hugegraph-doc/pull/511#discussion_r4221983338
##########
content/en/docs/contribution-guidelines/contribute.md:
##########
@@ -74,9 +81,21 @@ GitHub requires a username and token for Git authentication
instead of a usernam
When adding a third-party dependency, also update the license information
included in the distribution:
-1. Add the dependency's license file to
`hugegraph-server/hugegraph-dist/release-docs/licenses/`.
-2. Update `hugegraph-server/hugegraph-dist/release-docs/LICENSE`. If the
dependency includes a NOTICE file, update `NOTICE` as well.
-3. Run
`hugegraph-server/hugegraph-dist/scripts/dependency/regenerate_known_dependencies.sh`
to update the known-dependency list.
+1. Add the dependency's license file to `install-dist/release-docs/licenses/`.
+2. Update `install-dist/release-docs/LICENSE`. If the dependency includes a
NOTICE file, update `NOTICE` as well.
+3. From the repository root, prepare the current revision's Server, PD and
Store distribution libraries before regenerating the inventory:
+
+ ```bash
+ mvn clean install -DskipTests -Dmaven.javadoc.skip=true
Review Comment:
‼️ Critical: This root command invokes `clean` in the PD and Store
distribution modules, whose POMs at merged Server #3270 set `dist.dir` to
`${project.parent.basedir}` and pass that entire module root as a Clean Plugin
fileset without include or exclude patterns. Maven Clean's glob selector treats
an empty include list as matching every path. This can delete the contents of
`hugegraph-pd/` and `hugegraph-store/`, including sources, POMs and uncommitted
files, before packaging finishes. Please replace this with cleanup limited to
generated distribution outputs, or narrow the paired Clean filesets before
recommending the command; sync the Chinese guide. Evidence: [PD
dist.dir](https://github.com/apache/hugegraph/blob/7398075192446989e75ddb6512e13de442136365/hugegraph-pd/hg-pd-dist/pom.xml#L32-L34),
[PD Clean
fileset](https://github.com/apache/hugegraph/blob/7398075192446989e75ddb6512e13de442136365/hugegraph-pd/hg-pd-dist/pom.xml#L73-L80),
[Store dist.dir](https://github.com/apa
che/hugegraph/blob/7398075192446989e75ddb6512e13de442136365/hugegraph-store/hg-store-dist/pom.xml#L33-L35),
[Store Clean
fileset](https://github.com/apache/hugegraph/blob/7398075192446989e75ddb6512e13de442136365/hugegraph-store/hg-store-dist/pom.xml#L73-L80),
[Maven Clean
selector](https://github.com/apache/maven-clean-plugin/blob/maven-clean-plugin-3.1.0/src/main/java/org/apache/maven/plugins/clean/GlobSelector.java#L81-L122).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
