imbajin opened a new pull request, #3304: URL: https://github.com/apache/hugegraph/pull/3304
Store shutdown must wait for ordinary RPC callbacks and TTL native cleanup before destroying its databases. This change closes global RPC admission, stops the gRPC servers, drains application callbacks and retains TTL iterator-close failures after worker termination. The stop script preserves failure status and PID evidence on timeout. Depends on #3303 (org hugegraph/hugegraph#280). Merge RPC/Scan lifecycle first, then this PR. The org review https://github.com/hugegraph/hugegraph/pull/281 targets the RPC branch and shows only the shutdown delta; this ASF review temporarily includes that prerequisite until #3303 merges; after the RPC prerequisite merges, rebase onto master. It reuses the request services' scan/query registries and scoped drain. Interruption-safe engine/iterator prerequisites stay in #3303 to keep that intermediate version runnable; this PR adds no duplicate ownership model. The original tests are partitioned between Lifecycle and Shutdown classes with their assertions retained and shared helpers. Lifecycle tests run in #3303; this PR registers its application-wide shutdown tests in the same existing server suite. Required stop-script CI checks ship here. Validation: `git diff --check` passes. Split-stage independent review, compilation and runtime checks are in progress; previous combined-branch results are not presented as proof of this new split. Published non-draft for early review as requested. Doc - Done: `docs/store-shutdown.md`, lifecycle cross-links and Store README. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
