imbajin opened a new pull request, #799:
URL: https://github.com/apache/hugegraph-toolchain/pull/799

   ## Purpose of the PR
   
   The Go client accepted GraphSpace configuration for vertex/Gremlin requests 
but ignored it in schema requests. Existing schema operations now route to the 
configured space; an empty space retains the legacy path.
   
   Found in the [Toolchain integration 
report](https://github.com/hugegraph/hugegraph-toolchain/pull/47#issuecomment-6064536763).
   
   
   ![go schema: before and 
after](https://raw.githubusercontent.com/hugegraph/hugegraph-toolchain/7e0ff90eb82cf22597b40f0f97f7278ac55e5bdd/images/go-schema.png)
   
   ## Main Changes
   
   - Apply the existing GraphSpace route prefix to schema, property key, vertex 
label and edge label operations.
   - Preserve request methods, bodies, query parameters and HTTP error 
semantics.
   - Add actual HTTP request regressions for empty/default/custom spaces and 
path escaping. No missing APIs are implemented.
   
   ## Verifying these changes
   
   - [ ] Trivial rework / code cleanup without any test coverage. (No Need)
   - [ ] Already covered by existing tests.
   - [x] Need tests and can be verified as follows:
     - `go test -race -count=1 -timeout 30s ./api/v1/... -run 
'^TestSchemaGraphSpaceRoutes$' -v` passes.
     - The same request matrix rejects the original nonempty-space routes while 
preserving its empty-space behavior.
     - Three independent read-only reviews passed.
     - Authenticated private-space validation exercises every repaired schema 
method, rejects anonymous access, and independently checks that same-name 
DEFAULT schema is unchanged. Organization core CI passes.
   
   ## Does this PR potentially affect the following parts?
   
   - [x] Nope
   - [ ] Dependencies
   - [ ] Modify configurations
   - [ ] The public API
   - [ ] Other affects
   
   ## Documentation Status
   
   - [ ] `Doc - TODO`
   - [ ] `Doc - Done`
   - [x] `Doc - No Need`: fixes the behavior of the existing GraphSpace 
configuration.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to