imbajin opened a new pull request, #3306: URL: https://github.com/apache/hugegraph/pull/3306
## Purpose of the PR HStore advertises OLAP property support, but clearing or removing an existing OLAP property leaves its rows in the shared `ap` table. Cleanup now deletes only the selected property's rows and keeps other properties intact. Reported during [master integration testing](https://github.com/hugegraph/hugegraph-toolchain/pull/47#issuecomment-6064536763).  ## Main Changes - Scan the shared table and delete matching rows using their original keys and vertex owners, including legacy keys. - Commit bounded batches, reject pending graph mutations, and roll back a failed batch. - Reject inconsistent target compound rows instead of silently reporting successful cleanup. - Cover clearing, removing, repeated cleanup, property isolation, and failure paths; document batch semantics. ## Verifying these changes - [ ] Trivial rework / code cleanup without any test coverage. (No Need) - [ ] Already covered by existing tests. - [x] Need tests and can be verified as follows: - Targeted HStore session regressions pass. Original cleanup and the inconsistent-row regression fail their respective negative controls. - Current HStore implementation, session tests, and core lifecycle test compile under Java 17 with release 11. - Three independent readers reviewed the diff and re-reviewed the inconsistent-row fix. - The real HStore core lifecycle scenario passes, including clearing/removing one property while preserving another. Organization Actions is externally paused; upstream core CI remains required. ## Does this PR potentially affect the following parts? - [ ] Dependencies (add/update license info) - [ ] Modify configurations - [ ] The public API - [x] Other affects: existing HStore OLAP property cleanup - [ ] Nope ## Documentation Status - [ ] `Doc - TODO` - [x] `Doc - Done`: cleanup batching and failure semantics are documented. - [ ] `Doc - No Need` Documentation files in this PR or paired hugegraph-doc PR: `docs/shared-foundation-migration.md` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
