bitflicker64 commented on code in PR #519: URL: https://github.com/apache/hugegraph-doc/pull/519#discussion_r4262661224
########## content/en/docs/clients/restful-api/graphs.md: ########## @@ -215,6 +215,19 @@ Create a graph (set `Content-Type: application/json`) Graph-space management permission (`space`) is required when authentication is enabled. +Stop writes and tasks on every Server that uses the graph before deletion, and keep them stopped during failures and retries. +Do not recreate the same graph name until deletion has completed and been confirmed on every Server. Notifications are not a cluster-wide barrier. + +On the deleting Server, scheduler shutdown fences new task admission and waits for actual executions, cancellation callbacks and transaction cleanup. +If the configured task-drain wait times out (`task.wait_timeout`, seconds), deletion is refused before data, configuration or metadata removal; retry after +the owners exit. Task admission stays closed after this refusal. To resume ordinary graph use before destructive cleanup, keep writes and task producers stopped; +wait for all admitted tasks and cancellation cleanup to finish, then restart Server. A restart does not restore data or metadata already removed. +Closing the scheduler alone retains persistent work that has not started. + +Deletion is not transactional. A failure after destructive cleanup does not restore removed data or metadata. An uncertain owner or native-resource cleanup +needs manual inspection; do not force-remove the scheduler or resume writes just because a task Future is done. +If deletion is refused because the graph uses local configuration, remove its configuration file and restart Server before retrying. Review Comment: Important: for a graph that exists only as a local properties file, the retry this sentence asks for fails and its backend data is never cleared (same sentence at line 254 of the Chinese page). The refusal is the `localGraphs.contains(name)` check in the PD path of `GraphManager.dropGraph`, and `localGraphs` is filled only when `graph.load_from_local_config=true`. Such a graph is registered by `loadGraph(name, graphConfPath)`, which only puts it into `this.graphs`; `metaManager.addGraphConfig` is called from `createGraph` alone, so PD metadata has no entry for it. After the file is removed and Server restarts, `graph(graphSpace, name)` returns `null` and the retried `DELETE` stops at `E.checkArgumentNotNull(g, "The graph '%s' doesn't exist", name)`, before `clearBackend()`. The Server message itself only says to delete the config file and restart; "before retrying" is new in this PR. Requested change: in both languages, drop "before retrying" and say that removing the file and restarting only stops Server from loading the graph and leaves its backend data in place. Please also say that this refusal applies to PD deployments with `graph.load_from_local_config=true`; the non-PD path (`dropGraphLocal`) has no such check. ########## content/cn/docs/config/config-guide.md: ########## @@ -31,7 +31,7 @@ HugeGraphServer 内部集成了 GremlinServer 和 RestServer，而 gremlin-serve |------|------------|----------| | `conf/gremlin-server.yaml` | 随发行包提供；配置 Gremlin Server。 | `start-hugegraph.sh` 将它作为 Server 启动参数传入。 | | `conf/rest-server.properties` | 按固定 Server 主线构建时随发行包提供；配置 REST Server、PD、认证等。 | 启动脚本和 Server 进程读取；对应主线构建的容器入口脚本也会在启动前更新其中受支持的选项。 | -| `conf/graphs/hugegraph.properties` | 随发行包提供的默认图配置，使用 RocksDB。 | `init-store.sh` 和 Server 应用初始化都会扫描该目录；初始化阶段会尝试加载其中的图配置。`graph.load_from_local_config` 默认 `false`，只控制管理器构造阶段预加载及 `reload()` 重扫。 | +| `conf/graphs/hugegraph.properties` | 随发行包提供的默认图配置，使用 RocksDB。 | `init-store.sh` 和 Server 应用初始化都会扫描该目录；初始化阶段会尝试加载其中的图配置。`graph.load_from_local_config` 默认 `false`，控制管理器构造阶段预加载。 | Review Comment: Minor: this row now differs from its English counterpart. `content/en/docs/config/config-guide.md` line 34 ends with "Restart Server to apply graph configuration changes.", while this row stops at "控制管理器构造阶段预加载。". The other places this PR touches (the `graph.load_from_local_config` bullet in both guides, `config-option.md`, `config-backend-hstore.md`) carry the restart sentence in both languages. Requested change: append "图配置变化通过重启 Server 应用。" here, or remove the sentence from the English row, so the two tables say the same thing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
