arshilkxwork commented on code in PR #526:
URL: https://github.com/apache/hugegraph-doc/pull/526#discussion_r4262811747
##########
content/en/docs/config/config-option.md:
##########
@@ -69,6 +69,7 @@ Corresponding configuration file `rest-server.properties`
| auth.authenticator |
| The class path of authenticator implementation. e.g.,
org.apache.hugegraph.auth.StandardAuthenticator, or a custom implementation.
|
| auth.graph_store | hugegraph
| The name of graph used to store authentication information, like
users, only for org.apache.hugegraph.auth.StandardAuthenticator.
|
| auth.admin_pa | pa | Used when the Server startup path initializes admin.
Explicitly set a strong password before production deployment; the public
default is `pa`. On local persistent backends, `init-store.sh` prompts for the
initial password. |
+| auth.admin_pa_file | | Path of a file holding the initial password for the
built-in admin account. The file is read as raw UTF-8 with one trailing line
break removed, so spaces, backslashes and non-ASCII characters need no
properties escaping. When set, it takes precedence over `auth.admin_pa` and the
`init-store.sh` password prompt. A missing, empty or non-UTF-8 file stops
startup. Takes effect on first startup. |
Review Comment:
Fixed in 5d97063. The row now says the password is applied only when the
admin is first created, and that PD (hstore) and non-persistent backends read
the file on every start, so it has to stay readable while the option is set.
The hstore init-store paragraph and the `rest-server.properties` comment say
the same.
##########
content/cn/docs/config/config-option.md:
##########
@@ -69,6 +69,7 @@ search_boost: 1.5
| auth.authenticator |
| The class path of authenticator implementation. e.g.,
org.apache.hugegraph.auth.StandardAuthenticator, or a custom implementation.
|
| auth.graph_store | hugegraph
| The name of graph used to store authentication information, like
users, only for org.apache.hugegraph.auth.StandardAuthenticator.
|
| auth.admin_pa | pa
| Server 启动路径初始化内置 admin 账户时使用，默认值为公开的
`pa`，生产部署前必须显式设置强密码。本地持久化后端首次初始化由 `init-store.sh` 交互式读取密码。
|
+| auth.admin_pa_file |
| 存放内置 admin 账户初始密码的文件路径。文件按原始 UTF-8 读取，并去掉末尾的一个换行符，因此空格、反斜杠和非
ASCII 字符无需按 properties 语法转义。设置后优先于 `auth.admin_pa` 和 `init-store.sh`
的交互式密码输入。文件不存在、为空或不是合法 UTF-8 时启动失败。仅在首次启动时生效。 |
Review Comment:
Fixed in 5d97063 with the same wording as the EN row, and also in the CN
hstore page and properties comment.
##########
content/en/docs/config/config-option.md:
##########
@@ -69,6 +69,7 @@ Corresponding configuration file `rest-server.properties`
| auth.authenticator |
| The class path of authenticator implementation. e.g.,
org.apache.hugegraph.auth.StandardAuthenticator, or a custom implementation.
|
| auth.graph_store | hugegraph
| The name of graph used to store authentication information, like
users, only for org.apache.hugegraph.auth.StandardAuthenticator.
|
| auth.admin_pa | pa | Used when the Server startup path initializes admin.
Explicitly set a strong password before production deployment; the public
default is `pa`. On local persistent backends, `init-store.sh` prompts for the
initial password. |
+| auth.admin_pa_file | | Path of a file holding the initial password for the
built-in admin account. The file is read as raw UTF-8 with one trailing line
break removed, so spaces, backslashes and non-ASCII characters need no
properties escaping. When set, it takes precedence over `auth.admin_pa` and the
`init-store.sh` password prompt. A missing, empty or non-UTF-8 file stops
startup. Takes effect on first startup. |
Review Comment:
Fixed in 5d97063. Since your review, #3334 also gained 7ba00bd, which
requires a regular file (symlinks followed) and caps the password at 72 UTF-8
bytes. The rows and both properties comments now cover the BOM, the 4096-byte
file limit, the regular-file check and the 72-byte limit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
