arshilkxwork commented on code in PR #526:
URL: https://github.com/apache/hugegraph-doc/pull/526#discussion_r4265230921


##########
content/en/docs/config/config-option.md:
##########
@@ -69,6 +69,7 @@ Corresponding configuration file `rest-server.properties`
 | auth.authenticator                     |                                     
             | The class path of authenticator implementation. e.g., 
org.apache.hugegraph.auth.StandardAuthenticator, or a custom implementation.    
                                                    |
 | auth.graph_store                       | hugegraph                           
             | The name of graph used to store authentication information, like 
users, only for org.apache.hugegraph.auth.StandardAuthenticator.                
                                                              |
 | auth.admin_pa | pa | Used when the Server startup path initializes admin. 
Explicitly set a strong password before production deployment; the public 
default is `pa`. On local persistent backends, `init-store.sh` prompts for the 
initial password. |
+| auth.admin_pa_file | | Path of a regular file (symlinks are followed) 
holding the initial password for the built-in admin account. The file is read 
as raw UTF-8 with a leading BOM and one trailing line break removed, so spaces, 
backslashes and non-ASCII characters need no properties escaping. The password 
may be at most 72 bytes in UTF-8, because the password hash ignores anything 
after that. When set, it takes precedence over `auth.admin_pa` and the 
`init-store.sh` password prompt. A file that is missing, unreadable, not a 
regular file, larger than 4096 bytes, not valid UTF-8, empty, or holding a 
password longer than 72 bytes stops `init-store.sh` or Server startup. The 
password is only applied when the admin account is first created, but with PD 
(hstore) and non-persistent backends the file is read on every start, so keep 
it readable for as long as the option is set. |

Review Comment:
   Fixed in 877f8f4. The option rows, both `rest-server.properties` comments 
and both hstore paragraphs, in EN and CN, now say `auth.admin_pa_file` is only 
in versions after 1.7.0, and that a 1.7.0 or earlier Server ignores the key 
with a warning and uses `auth.admin_pa` (default `pa`), so `auth.admin_pa` 
still has to be set there. I followed the "1.7.0 and earlier / later versions" 
wording already used in `config-option.md` instead of naming 1.8.0, since 
apache/hugegraph#3334 has not merged yet.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to