imbajin commented on code in PR #814:
URL:
https://github.com/apache/hugegraph-toolchain/pull/814#discussion_r4265107871
##########
hugegraph-hubble/hubble-be/src/main/java/org/apache/hugegraph/entity/load/LoadTask.java:
##########
@@ -177,18 +177,34 @@ public void run() {
Ex.check(this.options != null, "The load options shouldn't be null");
log.info("LoadTask is start running : {}", this.id);
- boolean noError;
+ boolean noError = false;
+ boolean cleanupFailed = false;
+ Throwable failure = null;
try {
noError = this.loader.load();
} catch (Throwable e) {
- noError = false;
- log.error("Run task {} failed", this.id, e);
+ failure = e;
+ } finally {
+ try {
+ this.loader.shutdown();
Review Comment:
Verified this with the current paired changes in [Loader
#815](https://github.com/apache/hugegraph-toolchain/pull/815) and [Server
#3331](https://github.com/apache/hugegraph/pull/3331). An actual Hubble HTTP
start dispatched two CSV files through Spring/H2 and native async Loaders to
the same live standalone RocksDB graph. When the first task completed and
released its owner, the second was still running and the mode stayed LOADING;
it returned to NONE after the final release. Independent data readback and
direct context, worker-pool and shutdown-hook inspection passed.
An authenticated Chrome file chooser, mapping and Run Once import also
completed, with exact data readback, NONE and the other graph unchanged. The
current combined source and runtime evidence passed the same three independent
reviewers.
#814 releases Loader resources; the shared-mode protection requires the
paired owner-capable Client/Loader/Server changes. These PRs remain unmerged,
and PD/HStore, the broader pause/stop and role matrix, and full TC13 remain
separate gates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
