bitflicker64 commented on code in PR #814:
URL:
https://github.com/apache/hugegraph-toolchain/pull/814#discussion_r4268865399
##########
hugegraph-hubble/hubble-be/src/main/java/org/apache/hugegraph/entity/load/LoadTask.java:
##########
@@ -177,18 +177,34 @@ public void run() {
Ex.check(this.options != null, "The load options shouldn't be null");
log.info("LoadTask is start running : {}", this.id);
- boolean noError;
+ boolean noError = false;
+ boolean cleanupFailed = false;
+ Throwable failure = null;
try {
noError = this.loader.load();
} catch (Throwable e) {
- noError = false;
- log.error("Run task {} failed", this.id, e);
+ failure = e;
+ } finally {
+ try {
+ this.loader.shutdown();
Review Comment:
Correction: the row rejection I described here does not happen. The Loader
already rejects a vertex missing a non-null key before sending it
(`ElementBuilder.checkNonNullableKeys`), which is the same rule the Server
skips under LOADING (`GraphTransaction.java:340`). An early reset only makes
the graph report NONE while siblings still run, which #815 and
apache/hugegraph#3331 fix. Downgraded to Minor and non-blocking in my review at
5e0389b3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
