bitflicker64 commented on code in PR #3338:
URL: https://github.com/apache/hugegraph/pull/3338#discussion_r4267201081
##########
helm/hugegraph/templates/_helpers.tpl:
##########
@@ -15,6 +15,79 @@
# limitations under the License.
#
+{{/* Resolve inherited defaults once. Never use default/or for explicit
booleans. */}}
+{{- define "hugegraph.resolveValues" -}}
+{{- if not (get .Values "__hugegraphResolved") -}}
+{{- $_ := set .Values "__hugegraphResolved" true -}}
+{{- $legacy := not (hasKey .Values "mode") -}}
Review Comment:
Minor: Per the PR body and the #309 discussion, only `--reuse-values` keeps
a pre-0.2.0 release on ClusterIP without Hubble. A bare `helm upgrade`,
`-f`/`--set`, or `--reset-then-reuse-values` keeps the new `mode: easy`, so
`$legacy` is false. The Server Service becomes NodePort and a NodePort Hubble
is added. A release that already ran Hubble stops at the guard on line 862. The
docs cover this, but the upgrade output says nothing. Could NOTES.txt print a
short notice on `.Release.IsUpgrade` when `mode` and the Service types are
inherited (not set explicitly)? For example: "defaults changed in 0.2.0:
Server/Hubble now NodePort; see docs/operations.md#storage-and-upgrades". That
shows the exposure change at upgrade time without adding migration logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
