imbajin commented on code in PR #3338:
URL: https://github.com/apache/hugegraph/pull/3338#discussion_r4267285518
##########
helm/hugegraph/templates/_helpers.tpl:
##########
@@ -15,6 +15,79 @@
# limitations under the License.
#
+{{/* Resolve inherited defaults once. Never use default/or for explicit
booleans. */}}
+{{- define "hugegraph.resolveValues" -}}
+{{- if not (get .Values "__hugegraphResolved") -}}
+{{- $_ := set .Values "__hugegraphResolved" true -}}
+{{- $legacy := not (hasKey .Values "mode") -}}
Review Comment:
Added an upgrade-only NOTES notice naming the enabled Server/Hubble entries
that inherit NodePort, with a link to the storage-and-upgrades guide. Explicit
Service types and disabled Hubble are respected; fresh installs, strict-mode
upgrades and the legacy saved-values fixture do not receive this easy-default
notice. Helm coalesces mode values, so the condition uses effective easy mode
plus Service-type inheritance rather than claiming to distinguish explicit
mode: easy from the chart default. This is informational and adds no migration
logic or render gate. Helm template tests, lint, packaged-chart checks, legacy
saved-value renders and Kubernetes 1.23 manifest validation pass; no
live-cluster upgrade was performed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
