imbajin commented on code in PR #528:
URL: https://github.com/apache/hugegraph-doc/pull/528#discussion_r4286111113


##########
content/en/docs/config/config-guide.md:
##########
@@ -112,7 +112,11 @@ memory_monitor.period=2000
 - `graphs`: The graph configuration directory, defaulting to `./conf/graphs`. 
Both `init-store.sh` and application initialization scan it; initialization 
attempts to load its properties files.
 - `graph.load_from_local_config`: Controls constructor preloading and 
rescanning on `reload()`, with source-code default `false`. It does not block 
local loading during application initialization and is not a security isolation 
switch.
 
-> The upstream template still uses `arthas.telnet_port`, `arthas.http_port`, 
and `arthas.disabled_commands`, but `ServerOptions` reads the camelCase names 
in the example. Use `arthas.telnetPort`, `arthas.httpPort`, and 
`arthas.disabledCommands` in custom configurations.
+> Starting with HugeGraph 1.8.0, use canonical snake_case options: 
`arthas.telnet_port`, `arthas.http_port`, and `arthas.disabled_commands`.
+> Legacy camelCase names remain fallbacks; an explicitly set snake_case value 
wins and a conflicting alias produces a warning.

Review Comment:
   Added an upgrade notice in `config-guide.md` (both EN and CN) explaining 
that the shipped `rest-server.properties` template contains default snake_case 
settings (`arthas.telnet_port=8562`, `arthas.http_port=8561`, 
`arthas.disabled_commands=jad`), which take precedence over fallback camelCase 
aliases. Users upgrading with custom camelCase settings must migrate them to 
snake_case or delete the template lines. Also added cross-references to this 
notice in `config-option.md` and `other.md`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to