imbajin commented on code in PR #3349:
URL: https://github.com/apache/hugegraph/pull/3349#discussion_r4286367846
##########
helm/hugegraph/templates/tests/test-connection.yaml:
##########
@@ -78,7 +90,12 @@ spec:
PORT="{{ .Values.server.port }}"
FLOOR="{{ include "hugegraph.server.replicaFloor" . }}"
DEADLINE_S="${HG_TEST_DEADLINE_S:-150}"
- BODY={{ dict "gremlin" "graph.traversal().V().limit(1).count()"
"aliases" (dict "graph" (.Values.server.testGraphAlias | default
"DEFAULT-hugegraph")) | toJson | squote }}
+ BODY='{{ dict "gremlin" $smoke "aliases" (dict "graph"
.Values.server.testGraphAlias) | toJson | replace "'" "'\"'\"'" }}'
Review Comment:
Confirmed: the master merge had dropped the existing alias fallback.
Restored it in both the index-state and optional business request bodies.
Regression fixtures first reproduced `graph: null` for an explicit null and for
old coalesced chart defaults with the key absent; both now render
`DEFAULT-hugegraph`, while the explicit custom alias case still passes.
The socket-free hook suite, Helm template/package checks, Java 17
formatting/full compilation and independent final review passed. No live
service or cluster was started; current-head remote CI is still pending.
##########
.github/workflows/helm-chart-ci.yml:
##########
@@ -349,6 +349,19 @@ jobs:
expect "$(printf 'review\tsecret')" 'must be printable ASCII'
expect 'café' 'must be printable ASCII'
+ - name: helm test query assertions and shell quoting
+ run: |
+ # Execute the rendered query with the same Groovy version as Server.
+ GROOVY_VERSION=$(python3 - <<'PY_VERSION'
+ import xml.etree.ElementTree as ET
+ pom = ET.parse('pom.xml')
+ print(pom.find('{*}properties/{*}groovy.version').text)
+ PY_VERSION
+ )
+ curl -fsSLo /tmp/groovy.jar \
Review Comment:
Added the Maven Central `.sha1` download and native `sha1sum -c` check
before Groovy execution, using the existing version from the Server POM. I
executed the workflow download/checksum block: the original artifact passes and
a modified jar fails. This checks artifact integrity; it does not add an
authenticity guarantee or new dependency. The rendered Groovy fixtures and
required static/build checks pass; no service or cluster was started.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
