imbajin commented on code in PR #3357:
URL: https://github.com/apache/hugegraph/pull/3357#discussion_r4291112799
##########
hugegraph-pd/hg-pd-service/src/main/java/org/apache/hugegraph/pd/metrics/PDMetrics.java:
##########
@@ -111,6 +117,8 @@ private long updateGraphs() {
}
private long updateStores() {
+ // Registers the per-store gauges of stores that joined since the last
scrape
+ this.storeStateMetrics.refreshIfStale();
Review Comment:
🧹 Minor. Blocking: no. Summary: When a refresh is due, this scrape reads the
store prefix in `refreshIfStale()` and then reads it again for the count.
Please reuse the refreshed store list or count for `hg.stores`. Evidence:
`StoreInfoMeta.getStores()` delegates to `scanPrefix`, and `updateStores()`
calls `getStores()` immediately after the refresh.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
