arshilkxwork commented on PR #3357: URL: https://github.com/apache/hugegraph/pull/3357#issuecomment-6209849833
Thanks for the review. Addressed in 1ae51c92d: `hg.stores` now reports the size of the store list the per-store refresh just read, so a scrape scans the store prefix once instead of twice. On a failed read it keeps its last value, like the per-store gauges, where it used to report `0`. `testPrometheusScrape` counts the reads: two scrapes in one refresh interval read the store list once and print `hg_stores 1.0`. `hg-pd-service` tests: 21, 0 failures. The paired doc PR, apache/hugegraph-doc#531, now points at this commit; its text did not need changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
