bitflicker64 commented on code in PR #3358:
URL: https://github.com/apache/hugegraph/pull/3358#discussion_r4294282425
##########
helm/hugegraph/values.yaml:
##########
@@ -177,6 +177,8 @@ pd:
# election to lose and would otherwise pass /v1/health forever after losing
# leadership for good (apache/hugegraph#3222). Startup follows liveness so
# the boot-to-ready window sits inside the startup budget.
+ # TODO: drop the single-PD readiness derivation once the minimum supported
image
Review Comment:
Minor: This TODO says the single-PD derivation stays until the minimum
supported image has the fix, but the comment that explains the derivation now
contradicts the code in this PR. `helm/hugegraph/templates/_helpers.tpl` (the
`hugegraph.pd.livenessPath` block, lines 356-374) still says "/v1/health
answers 200 as soon as the REST listener is up and never consults raft", and it
ends by saying the value "stops being needed" once PD answers 503 from
`/v1/health`. After this PR `StoreAPI.checkHealthy()` does answer 503 for
`STATE_ERROR`, so that sentence now tells readers to drop the derivation, which
is the opposite of this TODO. Lines 177-178 above and the comment at
`helm/hugegraph/tests/pd_readiness_path_test.yaml:90` ("/v1/health would pass
forever") have the same problem.
Requested change: in the `_helpers.tpl` block, say that `/v1/health` stays
200 through elections and answers 503 on a fatal raft error from this image on.
Replace the last sentence with this TODO's condition: drop the derivation once
the minimum supported image has the fix. Limit the "pass /v1/health forever"
wording here and in the chart test to older images.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
