bitflicker64 commented on code in PR #3371:
URL: https://github.com/apache/hugegraph/pull/3371#discussion_r4303283491
##########
hugegraph-server/hugegraph-dist/src/assembly/travis/start-server.sh:
##########
@@ -64,18 +73,18 @@ write_property "$CONF" "serializer" "$SERIALIZER"
# Set timeout for hbase
if [ "$BACKEND" == "hbase" ]; then
- echo "restserver.request_timeout=200" >> $REST_CONF
- echo "gremlinserver.timeout=200" >> $REST_CONF
+ append_once "restserver.request_timeout=200" "$REST_CONF"
+ append_once "gremlinserver.timeout=200" "$REST_CONF"
sed_in_place 's/evaluationTimeout.*/evaluationTimeout: 200000/'
"$GREMLIN_CONF"
fi
# Set usePD=true for hstore
if [ "$BACKEND" == "hstore" ]; then
- echo "usePD=true" >> $REST_CONF
+ append_once "usePD=true" "$REST_CONF"
Review Comment:
Minor: This line is the fix for the hstore job, but the CI of this PR never
runs it: `gh pr checks 3371` lists `pd_store` and `compatibility /
build-server-backends` (hbase) as SKIPPED. `.github/scripts/ci-policy.py` maps
a `hugegraph-dist/` path to `{server, docker, macos, macos_full}` and adds
`hstore` only when the path contains `pd`, `store` or `distributed`, so
`start-server.sh` and `run-api-test.sh` never select hstore or hbase. That is
how #3366 merged with the hstore API step broken, and the next change to these
two scripts would hit the same blind spot. Requested change: add `TRAVIS +
"start-server.sh"` and `TRAVIS + "run-api-test.sh"` to the planner with
`{hstore, hbase}` (you offered this in the description; doing it here also lets
this PR's own CI run the hstore API step instead of relying on the out-of-CI
Ubuntu run).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
