bitflicker64 commented on code in PR #3371:
URL: https://github.com/apache/hugegraph/pull/3371#discussion_r4303712977
##########
hugegraph-server/hugegraph-dist/src/assembly/travis/start-server.sh:
##########
@@ -64,18 +73,18 @@ write_property "$CONF" "serializer" "$SERIALIZER"
# Set timeout for hbase
if [ "$BACKEND" == "hbase" ]; then
- echo "restserver.request_timeout=200" >> $REST_CONF
- echo "gremlinserver.timeout=200" >> $REST_CONF
+ append_once "restserver.request_timeout=200" "$REST_CONF"
+ append_once "gremlinserver.timeout=200" "$REST_CONF"
sed_in_place 's/evaluationTimeout.*/evaluationTimeout: 200000/'
"$GREMLIN_CONF"
fi
# Set usePD=true for hstore
if [ "$BACKEND" == "hstore" ]; then
- echo "usePD=true" >> $REST_CONF
+ append_once "usePD=true" "$REST_CONF"
Review Comment:
effa296fa covers these lines without the hstore and hbase jobs.
`test-start-server.sh` runs `start-server.sh` twice per backend and checks that
`usePD=true` (hstore), both timeouts (hbase) and `schema.sync_deletion=true`
(all backends) each end up once, only for their backend, and that the second
start changes nothing. It runs in the rocksdb job, which every `hugegraph-dist`
change selects, and fails on master's script. Touching `server-tests.yml` also
selects the hbase job, so this PR's CI now runs the real hbase API step with
both starts. The planner change is not in this PR: it would add hstore and
hbase runs to every change to these two scripts, so it is a separate decision.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
