bitflicker64 commented on code in PR #539:
URL: https://github.com/apache/hugegraph-doc/pull/539#discussion_r4303879100
##########
assets/scss/_styles_project.scss:
##########
@@ -711,23 +711,6 @@
}
}
-// Keep the fixed right rail above the visible footer, as the native left
panel does.
-@media screen and (min-width: 1200px) {
- .td-shell-layout:not(.td-shell-layout--toc-flow) .td-shell-toc__panel {
- inset-block-end: var(--td-shell-footer-offset, 0px);
- }
-}
-
-@media screen {
- // Keep technical tokens readable and let OINK's labelled, focusable wrapper
- // own overflow instead of collapsing identifiers one letter per line.
- .td-content .td-table-scroll > table :is(th, td),
Review Comment:
Important: This rule kept option names in one piece in every table. With it
gone, the latest Computer configuration page loses that protection, and nothing
replaces it there.
`content/en/docs/quickstart/computing/hugegraph-computer-config.md` has 32
`| config option | default value | description |` tables. The Chinese page has
34 `| 配置项 | 默认值 | 说明 |` tables. Neither page gets a `{.td-table--wide}` marker
in this PR, and the option names run up to 39 characters
(`worker.vertex_properties_combiner_class`,
`transport.max_timeout_heartbeat_count`). In OINK v1.3.1, an ordinary table
inherits `overflow-wrap: anywhere` from `.td-content` (`_content.scss` line 9).
It is also capped at `max-width: 100%` (`_brand.scss` line 234). Only
`table.td-table--wide` switches to `overflow-wrap: break-word; word-break:
normal` with `max-width: none` (`_content.scss` lines 199-216). So these option
names will break mid-token again, which is the behaviour this removed block
prevented. The archived copy of the same catalogue
(`config/config-computer.md`) is opted in by `ensure_legacy_config_tables_wide`
in `scripts/versioning.py`. The latest successor page is
not, and the new `configuration identifiers remain intact` test in
`tests/e2e/pd-table.spec.js` only visits `config-backend-hbase`,
`config-backend-hstore` and `config-option`, so CI cannot catch this.
Please add `{.td-table--wide}` after each config table in both language
versions of `quickstart/computing/hugegraph-computer-config.md`. Then add that
route to the identifier test, so the latest Computer catalogue gets the same
check as the archived one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
