bitflicker64 commented on code in PR #539:
URL: https://github.com/apache/hugegraph-doc/pull/539#discussion_r4304118587
##########
scripts/oink-overrides.json:
##########
@@ -89,14 +90,14 @@
"layouts/_partials/footer.html":
"6cbf0f74e6591b3235d47ed5cdad537c795508bd4af27e789962ec41f4b03544",
"layouts/_partials/hooks/body-end.html":
"e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855",
"layouts/_partials/hooks/head-end.html":
"e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855",
- "layouts/_partials/navbar-item.html":
"5db4e341e3cf1ec568942c6ba656f656763a9f703211511fe71d7ea8d4d58dee",
- "layouts/_partials/navbar.html":
"ae331609e5a072f83dd44898bee66561d711c258e785fe650796e400f5397f02",
+ "layouts/_partials/navbar-item.html":
"e74a029a6d502dae3f6b1e42ad331eaf9df4b0c7734e9ddefb1d7016fd08909f",
+ "layouts/_partials/navbar.html":
"e39b7e1eada012ed68409b8413616a5e0370f930552d29d0d9e16d0af2095aff",
"layouts/_partials/preset-config.html":
"3350bea094fcfdd11266d00505f64203a087f3b9d697142778ca10cffcc5ca78",
- "layouts/_partials/print/page-content.html":
"fb336ffbfd696df7506b5c4248dbfd88dea63d6e16f04aca0cbf93adc00f6244",
+ "layouts/_partials/print/page-content.html":
"0247138a2cb592716a54fd0cb2cd748c6fc23cec99055b808258da677624d8cf",
"layouts/_partials/seo-alternates.html":
"fa17d2bfa8f29884d13790f4a6fc9985f5a59833e1925906c8657bda082e86a3",
"layouts/_partials/share/bar.html":
"27918149bf9916994ecea61ee5ca2fae036d8d8438ba7faad802342419268101",
"layouts/_partials/shell/appearance-menu.html":
"883a454576b9dc4cfc50e95d438a864e4e301b3964cf4653b6a5e24b93541fd0",
- "layouts/_partials/shell/config.html":
"c7230e99b07f7d559ed371545983405a954ae69371de291b22567ade78b14560",
+ "layouts/_partials/shell/config.html":
"ca839c2b502af37ec2fa58d5b77a7d10994ba402142b8fad1659b411e64fedb0",
Review Comment:
Important: This records the OINK v1.3.1 `shell/config.html` as reviewed, but
the site's override of it was not updated. It still says "reviewed against
v1.1.0", and its line 38 keeps the old default `(slice "docs" "book" "blog"
"swagger")`. v1.3.1 added `"expo"` to that list, and `hugo.yaml` does not set
`params.ui.shell_types`.
So `shell/chrome-enabled.html` is false for `type: expo` pages, and on such
a page:
- `scripts.html` skips `js/docs-shell.js`, so the sidebar collapse and
drawer controls do nothing.
- `shell/search-enabled.html` turns local search off.
- `navbar.html` sets `$drawerMode` and `$landingSurface` to false, so phones
get no docs drawer.
The gallery itself still works. But the new `contribution.md` section tells
authors to build albums as "a section with `type: expo`", so the first such
album ships this broken shell. No page or test uses Expo yet.
Please add `"expo"` to the override's default and update its header. For
parity, also port the `isset` form of `quick_links`; that changes nothing here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
