byteayan commented on code in PR #535:
URL: https://github.com/apache/hugegraph-doc/pull/535#discussion_r4322566373
##########
content/en/docs/guides/hugegraph-docker-cluster.md:
##########
@@ -196,10 +196,19 @@ The following tables describe current master entrypoints
and Compose files, not
| `HG_STORE_GRPC_PORT` | No | `8500` | `grpc.port` |
| `HG_STORE_REST_PORT` | No | `8520` | `server.port` |
| `HG_STORE_DATA_PATH` | No | `/hugegraph-store/storage` | `app.data-path` |
+| `HG_STORE_ROCKSDB_TOTAL_MEMORY_SIZE` | No | None |
`rocksdb.total_memory_size`, in bytes |
{.td-table--wide}
> **Deprecated aliases**: `PD_ADDRESS` → `HG_STORE_PD_ADDRESS`, `GRPC_HOST` →
> `HG_STORE_GRPC_HOST`, `RAFT_ADDRESS` → `HG_STORE_RAFT_ADDRESS`.
+RocksDB caches live outside the Java heap. Leave
`HG_STORE_ROCKSDB_TOTAL_MEMORY_SIZE` unset to size them from the container
memory limit, or from the
Review Comment:
Fixed in 638a816e, EN and CN. The paragraph now says that leaving the
variable unset auto-sizes only when the loaded `rocksdb.total_memory_size` is
missing or `0`, that an `application-pd.yml` kept from an earlier release still
sets `32000000000` and keeps it, and it links the upgrade note in the HStore
configuration reference.
##########
content/en/docs/quickstart/hugegraph/hugegraph-hstore.md:
##########
@@ -132,6 +132,7 @@ docker run -d \
| `HG_STORE_GRPC_PORT` | No | `8500` | `grpc.port` | gRPC service port. |
| `HG_STORE_REST_PORT` | No | `8520` | `server.port` | REST API port. |
| `HG_STORE_DATA_PATH` | No | `/hugegraph-store/storage` | `app.data-path` |
Data path. |
+| `HG_STORE_ROCKSDB_TOTAL_MEMORY_SIZE` | No | None |
`rocksdb.total_memory_size` | RocksDB memory budget in bytes, digits only;
other values stop the entrypoint with exit code 2. When unset, the value in
`application-pd.yml` or auto-sizing applies. |
Review Comment:
Fixed in 638a816e, EN and CN: an empty value counts as unset, and only a
non-empty value must be digits, or the entrypoint exits with code 2. That
matches the `-n` gate and the entrypoint test's empty case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
