bitflicker64 commented on PR #535: URL: https://github.com/apache/hugegraph-doc/pull/535#issuecomment-6436988558
The earlier review comments below still apply at 1373759; this head does not fix them. - Important: `PdConfigureListener.restart()` runs `bin/restart-hugegraph-store.sh` with no arguments, so a Store started with `-j "-Xmx32g -Xms32g -XX:MaxDirectMemorySize=2g"` (as section 5.1 recommends) restarts with the launcher's default heap of at most 2 GiB, unlike a manual restart that forwards flags (section 5.3). Say that this self-restart drops `-j` and `-g`, so the `S:Timestamp` path keeps JVM settings only when they come from an exported `JAVA_OPTIONS`, and mirror it in the CN row. (https://github.com/apache/hugegraph-doc/pull/535#discussion_r4376347611) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
