arshilkxwork opened a new pull request, #851:
URL: https://github.com/apache/hugegraph-toolchain/pull/851
## Purpose of the PR
- close #672
`SameNeighborsBatchApiTest` exists but is not listed in `ApiTestSuite`, so
CI never runs it. #673 tried to add it and was blocked because the Server that
CI used then had no `/traversers/sameneighborsbatch` endpoint.
apache/hugegraph#2825 has since added the endpoint. The candidate Server that
client CI starts from the locked candidate SDK (apache/hugegraph `86c05ef9`)
includes it. The `release-1.7` baseline (`b12425c`) does not, and answers 404.
This picks up the change from #673 by @sadwitdastreetz and handles the
version gap.
## Main Changes
- `ApiTestSuite` lists `SameNeighborsBatchApiTest` after
`SameNeighborsApiTest`.
- At the end of the class's `@BeforeClass`, once the test vertices exist, it
posts one batch request. A 404 skips the whole class through `Assume`, so the
`release-1.7` job reports it as skipped instead of failing. Any other error is
rethrown. `BaseApiTest`'s `@AfterClass` still clears the data when the class is
skipped.
- The test methods are unchanged.
## Verifying these changes
- [ ] Trivial rework / code cleanup without any test coverage. (No Need)
- [ ] Already covered by existing tests, such as *(please modify tests
here)*.
- [x] Need tests and can be verified as follows:
- Built Server from apache/hugegraph master at `969bb1420`, started it
with `hugegraph-client/assembly/travis/start-hugegraph-servers.sh` as client CI
does, and ran `mvn test -Dtest=SameNeighborsBatchApiTest`: 5 tests, 0 failures.
- Against the same Server, with the client's batch path temporarily
pointed at a missing endpoint so the Server answered 404: the class was
reported as skipped, with no failures. The client change was reverted
afterwards.
- Not verified locally: the full `ApiTestSuite`. On this machine the
Server started with a 512 MB heap and began answering 503 ("available memory
... below than threshold 64(MB)") across many classes, before and independent
of this test, so those runs say nothing about this change. CI's candidate and
`release-1.7` jobs run the full suite.
- Not run against a real 1.7.0 Server; the `release-1.7` CI job covers
the skip path.
## Does this PR potentially affect the following parts?
- [x] Nope
- [ ] Dependencies (add/update license info)
- [ ] Modify configurations
- [ ] The public API
- [ ] Other affects (typed here)
## Documentation Status
- [ ] `Doc - TODO`
- [ ] `Doc - Done`
- [x] `Doc - No Need`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
