arshilkxwork commented on code in PR #851:
URL: 
https://github.com/apache/hugegraph-toolchain/pull/851#discussion_r4380045956


##########
hugegraph-client/src/test/java/org/apache/hugegraph/api/ApiTestSuite.java:
##########
@@ -76,6 +77,7 @@
         CountApiTest.class,
         RingsRaysApiTest.class,
         SameNeighborsApiTest.class,
+        SameNeighborsBatchApiTest.class,

Review Comment:
   Fixed in 804f0317. The `limit(2)` and `limit(1)` blocks now set their 
options and then post `builder.build()`, instead of reposting the first 
request. With `limit(1)` the first two pairs return one neighbor each, so the 
check asserts sizes 1, 1 and 0, and that the kept neighbor is one of the two 
the pair shares ({3, 4} and {1, 2}), since the API does not specify which one 
is kept. `limit(2)` still returns both shared neighbors.
   
   Checked against a Server built from apache/hugegraph master at e497efd99, 
started with `start-hugegraph-servers.sh`: `SameNeighborsBatchApiTest` passes, 
5 tests, 0 failures.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to