imbajin commented on code in PR #3427: URL: https://github.com/apache/hugegraph/pull/3427#discussion_r4399563640
########## helm/hugegraph/README.md: ########## @@ -263,7 +259,12 @@ ClusterIP is an internal virtual service address, not a node IP. An ordinary laptop usually cannot reach it directly. With default `externalTrafficPolicy: Cluster`, NodePort can forward through a node that does not host the target Pod. -To fix a NodePort, set `server.service.nodePort` or `hubble.service.nodePort`. +Native HTTP supports only ClusterIP/NodePort. A null `service.type` inherits the +mode; existing explicit ClusterIP values stay private. Legacy releases without +`mode` retain ClusterIP. Entry commands are in the [SeaTunnel](docs/seatunnel.md) Review Comment: Non-blocking upgrade clarification: the legacy fallback applies only when the effective merged values lack `mode`. An upgrade that imports the new chart defaults can instead inherit `mode: easy` and NodePort if the previous user values never explicitly set the native Service type; preserving an explicit ClusterIP is a different case. Could this paragraph tell operators who want to retain private entries to explicitly set `seatunnel.service.type: ClusterIP` and `vermeer.service.type: ClusterIP`, and qualify the legacy sentence accordingly? The legacy test removes `mode` from the chart defaults, so it does not establish preservation across every upgrade/reset/reuse path. Source: https://github.com/apache/hugegraph/blob/9339143b48e0031150deb18d9ec58157fa9ee7f6/helm/hugegraph/README.md#L262-L265 Evidence boundary: 26 exact-schema boundary cases passed independently on dots; no Helm upgrade/render or live CNI test was executed. This is a documentation clarification, not a claim that every upgrade changes exposure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
