bitflicker64 commented on PR #386:
URL: https://github.com/apache/hugegraph-ai/pull/386#issuecomment-6465113186
## Review summary: R1 at `b7bdd105`
**Score: 10/10, no confirmed defects.** This verdict covers base `94342bec`
→ head `b7bdd1050be948b5b70a66db620a03d9db8e631d` only. The PR head has since
moved to `6f8843e3` (release tooling, docs and test follow-ups in
`scripts/version.py`, `scripts/ci.py`, `scripts/apache-release.sh` and
READMEs), which this round did **not** review.
**Lanes:** 2 of 4 in (Codex, Claude). Copilot and AGY are still pending and
will be added to this comment if they report.
Both lanes reviewed the whole PR independently. Each one:
- read `AGENTS.md` and `hugegraph-llm/AGENTS.md`
- ran `python3 -m unittest discover -s scripts/tests` (37 passed) and
`scripts/version.py check` (rc=0)
**Not scored (follow-up suggestions):**
- **Unpinned server image in CI.** CI now runs integration tests against
`hugegraph/hugegraph:latest`, and `scripts/check_hugegraph.sh` requires an
exact match with the root version. Base pinned `1.7.0`, so this coupling is new.
- Today `latest` reports `1.8.0`, so CI passes.
- Once Server publishes a newer `latest`, unrelated llm/client/mcp jobs
will fail until the root version changes. The failure is loud and clearly
worded, which looks intentional.
- A pinned tag or digest would keep CI reproducible.
- **Floating linter versions.** `ruff.yml` installs `ruff`/`ty` with `>=`
bounds, so a new upstream release can turn unrelated PRs red.
- **Docker changes have no build check.** `docker/` and `.dockerignore`
changes select llm tests, but no workflow builds the image. This gap already
existed at base.
**Limits:**
- No Docker image build, full module pytest or integration run.
- The Codex lane's tool transcript is on another host, so its skill and
guidance receipts are taken from its report.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
